Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly sideload child images and account for some common use cases when converting images #27

Merged
merged 10 commits into from
Aug 12, 2024

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented Aug 6, 2024

Fixes #26

  • Ensures that child images are properly sideloaded.
  • Account for converting a <figure> and other common uses to an image block.
  • Add collection of attachments that are created during the conversion process.
    Two methods now exist on the converter to help:
    • get_created_attachment_ids() - Returns the attachment IDs that were created.
    • assign_parent_to_attachments() - Assigns a parent post to all attachments.

Copy link

@attackant attackant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐙

@srtfisher srtfisher merged commit 9679a9c into develop Aug 12, 2024
5 checks passed
@srtfisher srtfisher deleted the hotfix/inline-image branch August 12, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested images aren't properly sideloaded
2 participants